hvs pg rotating secret #1130
Open
hvs pg rotating secret #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averche
reviewed
Nov 12, 2024
|
|
||
| // Inner API-compatible models derived from the Terraform fields | ||
| capabilities []*secretmodels.Secrets20231128Capability `tfsdk:"-"` | ||
| staticCredentialDetails *secretmodels.Secrets20231128PostgresStaticCredentialsRequest `tfsdk:"-"` |
There was a problem hiding this comment.
We may need to add a gateway pool ID here as well
There was a problem hiding this comment.
should we introduce that separately (in a diff PR) or here?
are (should) gateways be added to the tf provider?
There was a problem hiding this comment.
I'd opt for here since a postgres integration is not particularly useful without a gateway
averche
reviewed
Nov 14, 2024
| Import is supported using the following syntax: | ||
|
|
||
| ```shell | ||
| terraform import hcp_vault_secrets_integration_confluent.example my-postgres-1 |
There was a problem hiding this comment.
One more confluent reference :)
…rovider-hcp into dh/hvs-pg-rotating
…to dh/hvs-pg-rotating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add new postgres integration resource and add postgres rotating secret
HV-1704
HV-1707
🛠️ Description
🏗️ Acceptance tests
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX' ...