fix(tfe_policy): update query if changed #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-stitt
approved these changes
Nov 27, 2023
glennsarti
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Looks good from the compliance team!
Thanks for the PR @skeggse !
nfagerlund
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
- Fix is valid. Many thanks for catching that. 👍🏼
- (This
ifcondition is a menace in the first place and probably shouldn't be here. If the SDK thinks we need to run the update func at this point, it should build the update opts struct unconditionally.) - As previous reviewers noted, this needs a test. It sounds like you're done here, so I'm going to replace this PR once I get a test written. No one merge this in the meantime, please.
| ## UNRELEASED | ||
|
|
||
| BUG FIXES: | ||
| * `r/tfe_policy`: Fix the provider ignoring updates to the `query` field and pretending it issued an API call when it didn't. |
There was a problem hiding this comment.
Suggested change
| * `r/tfe_policy`: Fix the provider ignoring updates to the `query` field and pretending it issued an API call when it didn't. | |
| * `r/tfe_policy`: Fix the provider ignoring updates to the `query` field. |
Valid to be grouchy about an aggravating bug 👍🏼, but I think we can leave "ignores it -> definition of ignoring it" as an exercise for the reader.
Merged
|
Moved your commits to #1154 and unskipped the resource integration tests |
opentofu-provider-sync-service-account
pushed a commit
to opentofu/terraform-provider-tfe
that referenced
this pull request
Nov 28, 2023
…y_policyset Unfork hashicorp#1108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I tried to update the
queryof a policy, and it didn't update - but the state thought it did! 🤦Remember to:
Testing plan
I'm not going to spend the time to test this independently - it's too much effort. If it builds, someone else can try testing this. It's rather upsetting that this sort of bug is even possible in this Terraform provider.
External links
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
Feel free to do this.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.