Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-9700 Add a new project_oauth_client resource #1144

Merged
merged 11 commits into from
Apr 10, 2024

Conversation

Netra2104
Copy link
Contributor

@Netra2104 Netra2104 commented Nov 16, 2023

Description

New endpoints in atlas have been added that add a project relationship to an oauth client. Supporting functions have been added to go-tfe as well.

Note: this is a beta feature as this PR might be merged before the TFC launch. There will be a PR in the future to remove the beta flags.

Remember to:

Testing plan

Run the unit tests locally.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

--- PASS: TestAccTFEProjectOAuthClient_basic (10.16s)
PASS

--- PASS: TestAccTFEProjectOAuthClient_incorrectImportSyntax (8.24s)
PASS

Documentation Output

Screenshot 2023-11-17 at 9 52 30 AM
Screenshot 2023-11-17 at 9 52 38 AM

@Netra2104 Netra2104 added the wip label Nov 16, 2023
@Netra2104 Netra2104 requested a review from a team as a code owner November 16, 2023 21:46
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9700-oauth_client_project_resource branch from 162a7d3 to 8b10ed5 Compare November 17, 2023 14:57
@Netra2104 Netra2104 requested a review from a team November 20, 2023 17:56
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this feature behind a feature flag? Then you probably want to add a note that this beta feature and subject to change.

@hs26gill hs26gill force-pushed the Netra2104/TF-9700-oauth_client_project_resource branch from 8b10ed5 to 4f727a7 Compare November 22, 2023 17:44
@hs26gill
Copy link
Contributor

Please fix the lint issues, otherwise, LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
@Netra2104 Netra2104 force-pushed the Netra2104/TF-9700-oauth_client_project_resource branch from afc706c to 99e6e4f Compare November 29, 2023 14:11
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. There's a lot of flexibility in managing these while changing organization_scoped on the oauth client. They don't invalidate each other on the API when setting organization_scoped to true. I can merge this if that test doesn't start cooperating.

@netramali
Copy link
Contributor

This looks fine. There's a lot of flexibility in managing these while changing organization_scoped on the oauth client. They don't invalidate each other on the API when setting organization_scoped to true. I can merge this if that test doesn't start cooperating.

@brandonc Can you please go ahead and merge it. Thanks!

@netramali netramali merged commit 3795aeb into main Apr 10, 2024
9 checks passed
@netramali netramali deleted the Netra2104/TF-9700-oauth_client_project_resource branch April 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants