-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF-9700 Add a new project_oauth_client resource #1144
TF-9700 Add a new project_oauth_client resource #1144
Conversation
162a7d3
to
8b10ed5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature behind a feature flag? Then you probably want to add a note that this beta feature and subject to change.
8b10ed5
to
4f727a7
Compare
Please fix the lint issues, otherwise, LGTM! |
afc706c
to
99e6e4f
Compare
removed beta tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. There's a lot of flexibility in managing these while changing organization_scoped on the oauth client. They don't invalidate each other on the API when setting organization_scoped to true. I can merge this if that test doesn't start cooperating.
@brandonc Can you please go ahead and merge it. Thanks! |
Description
New endpoints in atlas have been added that add a project relationship to an oauth client. Supporting functions have been added to go-tfe as well.
Note: this is a beta feature as this PR might be merged before the TFC launch. There will be a PR in the future to remove the beta flags.
Remember to:
Testing plan
Run the unit tests locally.
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.
Documentation Output