[IPL-5689] Revert the fix for no changes detected when provider default org changes on Registry Modules

[hashimoon]

This fixes a bug that always forced a registry module to always be recreated when a default organization is not provided..

Description

Describe why you're making this change.

Remember to:

• Update the Change Log
• Update the Documentation

Testing plan

1. Perform

terraform apply

with the below code (fill out your values for identifiers and oauth_token_id):

terraform {
  required_providers {
    tfe = {
      source = "hashicorp/tfe"
      version = "0.49.0"
    }
  }
}
resource "tfe_registry_module" "test-registry-module" {
  vcs_repo {
    display_identifier = "your/display-identifier"
    identifier         = "your/identifier"
    oauth_token_id     = "ot-oauth-token-id"
  }
}

2. Change the version of the provider to 0.51.0
3. Perform

terraform init -upgrade

4. Perform

terraform plan

Expected behavior
Since the resource is not changed but only the version of the provider the resource should not be recreated.

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

• go-tfe documentation
• API documentation
• Related PR

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

[brandonc]

This is good because the organization attribute in this particular resource is fundamentally different from the others and it was added by mistake. Usually, organization is optional because it can appear in the provider. In this case, it's just optional!