Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-11504 add description to projects #1271

Merged
merged 14 commits into from
Apr 23, 2024
Merged

TF-11504 add description to projects #1271

merged 14 commits into from
Apr 23, 2024

Conversation

netramali
Copy link
Contributor

@netramali netramali commented Mar 1, 2024 •
edited
Loading

Description

Description attribute is added to projects in atlas.

Remember to:

Testing plan

Integration tests

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

=== RUN   TestAccTFEProject_basic
--- PASS: TestAccTFEProject_basic (6.15s)
PASS

=== RUN   TestAccTFEProject_update
--- PASS: TestAccTFEProject_update (6.52s)
PASS

datasource:
=== RUN   TestAccTFEProjectDataSource_basic
--- PASS: TestAccTFEProjectDataSource_basic (8.07s)
PASS
Screenshot 2024-03-01 at 9 55 15 AM

@netramali netramali requested a review from a team as a code owner March 1, 2024 14:58
@netramali netramali changed the title Netramali/tf 11504 add description to projects TF-11504 add description to projects Mar 1, 2024
Maed223
Maed223 previously requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@Maed223 Maed223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍, just the CHANGELOG that needs adjustment

CHANGELOG.md Show resolved Hide resolved
internal/provider/data_source_project_test.go Outdated Show resolved Hide resolved
@netramali @Maed223
Update CHANGELOG.md
9c8551d 
Co-authored-by: Mark DeCrane <[email protected]>
@jbonhag jbonhag requested a review from a team April 23, 2024 14:53
hs26gill
hs26gill approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@hs26gill hs26gill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@netramali netramali merged commit d2e4c2a into main Apr 23, 2024
9 checks passed
@netramali netramali deleted the netramali/TF-11504-add-description-to-projects branch April 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenolivia laurenolivia laurenolivia left review comments

@hs26gill hs26gill hs26gill approved these changes

@Maed223 Maed223 Maed223 left review comments

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netramali @hs26gill @laurenolivia @Maed223