-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for test environment variables #1285
Conversation
Would you mind adding some docs for this resource to the website/docs/r directory? It would help our reviewing considerably. I also noticed a couple of things outright: is the resource importable? In the schema, organization is defined as optional but seems to be treated as required. See the other provider_next resources for proper org schema handling, because it may also come from the default defined in the provider config. |
The resource is not importable at this time - but that may change if a good use case for it arises. I've updated the required fields in the schema and added documentation. Please let me know if theres anything else I can do to facilitate the review process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with provider code, and so the review is mostly questions. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Description
This PR adds support for test environment variables to the tfe-provider. It does so in a separate
tfe_test_variable
as opposed to adding this to thetfe_variable
resource. Thetfe_variable
resource currently supports workspace level variables and variable set level variables and parses HCL to determine which it's using. A new tfe_test specific variable was implemented to not contribute further to the complexity of thetfe_variable
resource as well as to maintain the simplicity of thetfe_test_variable
resource.Remember to:
Testing plan
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.