Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post_apply to list of stages #1307

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

carolinaborim
Copy link
Contributor

@carolinaborim carolinaborim commented Apr 5, 2024

Description

Add post_plan to list of stages

Remember to:

Testing plan

N/A

External links

Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.

Output from acceptance tests

N/A

@carolinaborim carolinaborim marked this pull request as ready for review April 5, 2024 07:11
@carolinaborim carolinaborim requested a review from a team as a code owner April 5, 2024 07:11
Copy link
Contributor

@glennsarti glennsarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolinaborim carolinaborim changed the title Add post_plan to list of stages Add post_apply to list of stages Apr 8, 2024
Copy link
Contributor

@Uk1288 Uk1288 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🎉 , we can close the PR (#1304) which does the same go-tfe version bump once we merge this PR

@carolinaborim carolinaborim merged commit 0772bfb into main Apr 8, 2024
10 checks passed
@carolinaborim carolinaborim deleted the carolinaborim/add-post-apply branch April 8, 2024 08:43
@MXfive
Copy link

MXfive commented Jul 18, 2024

@glennsarti Was this change or something else needed on the new stages attribute added in #1330 ?

We are seeing this error when trying to migrate off this deprecated attribute.

Screenshot 2024-07-18 at 17 34 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants