-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Granular Permissions to Manage Teams to Team Org Access #1313
Merged
brandonc
merged 4 commits into
main
from
juliannatetreault/TF-14029-add-manage-permissions
May 9, 2024
Merged
Add Granular Permissions to Manage Teams to Team Org Access #1313
brandonc
merged 4 commits into
main
from
juliannatetreault/TF-14029-add-manage-permissions
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
April 17, 2024 13:43
7cbd84a
to
ae275f1
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
April 24, 2024 21:51
ae275f1
to
366a72d
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
April 30, 2024 17:31
366a72d
to
90958ba
Compare
emlanctot
reviewed
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked this out locally and tested different combinations of team management permissions and it works! i'll approve when the PR's in the review state!
emlanctot
approved these changes
May 3, 2024
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
May 8, 2024 13:09
d8c12d5
to
5d53f0e
Compare
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
May 9, 2024 15:41
5918c42
to
3ca2436
Compare
brandonc
approved these changes
May 9, 2024
juliannatetreault
force-pushed
the
juliannatetreault/TF-14029-add-manage-permissions
branch
from
May 9, 2024 16:07
6eb08ce
to
78b1e35
Compare
JarrettSpiker
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support that will allow the
manage_teams
,manage_organization_access
, andaccess_secret_teams
organization access settings to be set on teams via the provider.Remember to:
Testing plan
manage_teams
,manage_organization_access
, andaccess_secret_teams
should default tofalse
for new teams.manage_teams
,manage_organization_access
, and/oraccess_secret_teams
is omitted, they should default tofalse
.manage_teams
,manage_organization_access
, andaccess_secret_teams
should be able to be set or unset via the provider.External links
Output from acceptance tests