Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Granular Permissions to Manage Teams to Team Org Access #1313

Merged
merged 4 commits into from
May 9, 2024

Conversation

juliannatetreault
Copy link
Contributor

@juliannatetreault juliannatetreault commented Apr 17, 2024

Description

This PR adds support that will allow the manage_teams, manage_organization_access, and access_secret_teams organization access settings to be set on teams via the provider.

Remember to:

Testing plan

  1. manage_teams, manage_organization_access, and access_secret_teams should default to false for new teams.
  2. If manage_teams, manage_organization_access, and/or access_secret_teams is omitted, they should default to false.
  3. manage_teams, manage_organization_access, and access_secret_teams should be able to be set or unset via the provider.

External links

Output from acceptance tests

$ TESTARGS="-run TestAccTFEWorkspace" make testacc

...

@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from 7cbd84a to ae275f1 Compare April 17, 2024 13:43
@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from ae275f1 to 366a72d Compare April 24, 2024 21:51
@juliannatetreault juliannatetreault requested a review from a team April 24, 2024 21:51
@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from 366a72d to 90958ba Compare April 30, 2024 17:31
Copy link
Contributor

@emlanctot emlanctot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked this out locally and tested different combinations of team management permissions and it works! i'll approve when the PR's in the review state!

@juliannatetreault juliannatetreault marked this pull request as ready for review May 3, 2024 13:04
@juliannatetreault juliannatetreault requested a review from a team as a code owner May 3, 2024 13:04
go.mod Outdated Show resolved Hide resolved
@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from d8c12d5 to 5d53f0e Compare May 8, 2024 13:09
@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from 5918c42 to 3ca2436 Compare May 9, 2024 15:41
CHANGELOG.md Outdated Show resolved Hide resolved
@juliannatetreault juliannatetreault force-pushed the juliannatetreault/TF-14029-add-manage-permissions branch from 6eb08ce to 78b1e35 Compare May 9, 2024 16:07
@brandonc brandonc merged commit 36bc849 into main May 9, 2024
6 checks passed
@brandonc brandonc deleted the juliannatetreault/TF-14029-add-manage-permissions branch May 9, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants