Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove force new modifier on name attribute #566

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

sebasslash
Copy link
Contributor

Description

The issue was reported here.

Effectively, the ForceNew modifier was set in the name attribute of the r/tfe_team schema causing the recreation of the team resource whenever the name was updated.

This PR removes this as there isn't any API specific behavior that requires the team to be recreated upon a name change.

Testing plan

In order to smoke test this, we'll need a simple configuration that provisions a team (ensure your organization is not on the free tier):

resource "tfe_team" "foo" {
  name = "the-foo-fighters"
  organization = "rocknroll"
}

Create the team first using terraform apply and then simply modify the name, running terraform apply again. Overriding the provider to a local build including my changes, you should see that the team is no longer recreated.

@sebasslash sebasslash requested a review from a team as a code owner July 25, 2022 20:57
Copy link
Collaborator

@brandonc brandonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always been possible to update a team name! 👍

@sebasslash sebasslash merged commit 3e19db2 into main Jul 25, 2022
@sebasslash sebasslash deleted the remove-force-new branch July 25, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants