build(deps): Bump github.com/hashicorp/terraform-plugin-framework from 1.5.0 to 1.6.0 #479
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/hashicorp/terraform-plugin-framework](https://github.com/hashicorp/terraform-plugin-framework) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/hashicorp/terraform-plugin-framework/releases) - [Changelog](https://github.com/hashicorp/terraform-plugin-framework/blob/main/CHANGELOG.md) - [Commits](hashicorp/terraform-plugin-framework@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/terraform-plugin-framework dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
lgtm, left two comments, ref: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175
| @@ -208,7 +208,7 @@ func TestAccDataSourceCertificate_BadSSL(t *testing.T) { | |||
| r.TestCheckResourceAttr("data.tls_certificate.test", "certificates.1.signature_algorithm", "SHA256-RSA"), | |||
| r.TestCheckResourceAttr("data.tls_certificate.test", "certificates.1.public_key_algorithm", "RSA"), | |||
| r.TestCheckResourceAttr("data.tls_certificate.test", "certificates.1.is_ca", "false"), | |||
| r.TestCheckResourceAttr("data.tls_certificate.test", "certificates.1.sha1_fingerprint", "a33e459e760bff66228f99ab9c3c4b0259afaf6c"), | |||
| r.TestCheckResourceAttr("data.tls_certificate.test", "certificates.1.sha1_fingerprint", "6922cd864f3c6299f6e751a019e5ddcdbc415a71"), | |||
There was a problem hiding this comment.
I should have done this when I did the same update last year in #348, but can you add a comment describing that this value is expected to change? (for future maintainers)
There was a problem hiding this comment.
Good shout. Have added a maintainer note.
internal/provider/common_cert.go
Outdated
| case *ecdsa.PublicKey: | ||
| //nolint:staticcheck // Although Marshal is deprecated we cannot just switch to using p = pub.ECDH(), p.Bytes() | ||
| pubKeyBytes = elliptic.Marshal(pub.Curve, pub.X, pub.Y) |
There was a problem hiding this comment.
I have little to no domain knowledge of the Go function being deprecated here 😞 . But in general I feel like if this needs more research to determine how best to replace this deprecated function, we should do it outside of this PR. (it doesn't feel like an urgent thing, maybe a gardening thing 🧑🌾 )
Can you dump any context you may have about the deprecation into a new GH issue and link it in this nolint comment?
There was a problem hiding this comment.
Have added a note linking to #480
bendbennett
deleted the
dependabot/go_modules/github.com/hashicorp/terraform-plugin-framework-1.6.0
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Bumps github.com/hashicorp/terraform-plugin-framework from 1.5.0 to 1.6.0.
Release notes
Sourced from github.com/hashicorp/terraform-plugin-framework's releases.
Changelog
Sourced from github.com/hashicorp/terraform-plugin-framework's changelog.
Commits
f35653eUpdate changeloga995991function: Replace usage of diagnostics with function errors during execution ...3c7a391reflect: Determine equivalency of float32 or float64, and *big.Float via stri...8d0d29ddocs: add import statements to default-values.mdx (#851)a8189f1function: Switch the representation of variadic arguments totypes.Tuple(#...bcbb70bResult of tsccr-helper -log-level=info gha update -latest . (#924)86b2acbresource: Initial MoveResourceState RPC support (#917)f471850Result of tsccr-helper -log-level=info gha update -latest . (#918)f2e8b33build(deps): Bump hashicorp/setup-terraform from 2.0.3 to 3.0.0 (#916)0185b95Added GHA dependabot config for managing hashicorp actions (#915)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)