-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
provider/aws: fix ECS service CheckDestroy in tests
- Loading branch information
Showing
1 changed file
with
5 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47f8b0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ClusterNotFoundException
is actually a valid error which shouldn't be ignored, the real cause is that we're not passingCluster
attribute toDescribeServices
few lines above - hence it uses the default cluster (nameddefault
I think), which may not exist.Besides that, there's actually more to be fixed in ECS service deletion.
I'm fixing all the things I know about already in MeredithCorpOSS@86269da#diff-541cd13c0077eb59a7e6688908a5cc8eR217 ( #4366 )
47f8b0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops good catch! I've been doing a big sweep getting the acctests green and definitely let this one slip. Will keep an eye on #4366 for your legitimate fixes. 👍
47f8b0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #4366 is ready for review