provider/datadog: Default notify_no_data on datadog_monitor to false

[stack72]

Fixes: #11863

Backwards incompatible so will not be pushed to 0.8.x series.

This follows the datadog documentation as mentioned in the issue

% make testacc TEST=./builtin/providers/datadog TESTARGS='-run=TestAccDatadogMonitor_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/13 12:30:24 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v -run=TestAccDatadogMonitor_ -timeout 120m
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (84.23s)
=== RUN   TestAccDatadogMonitor_BasicNoTreshold
--- PASS: TestAccDatadogMonitor_BasicNoTreshold (81.92s)
=== RUN   TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (82.91s)
=== RUN   TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (63.34s)
=== RUN   TestAccDatadogMonitor_Basic_float_int
--- PASS: TestAccDatadogMonitor_Basic_float_int (75.84s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/datadog	388.257s

[grubernaut]

LGTM!

[stephenchu]

Just wanted to call out that this commit contains backward incompatible changes, but did not make it to the list in 0.9.0 CHANGELOG.

[stack72]

Hi @stephenchu

Can you tell me what the backwards incompatible changes were? I'd like to make sure I get them in the changelog

Sorry for this

Paul

[stephenchu]

This commit fixes the datadog_monitor's notify_no_data attribute default value from true to false (i.e. to align with datadog's default). The mentioned bug (#11863) has more.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.