Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/datadog: Default notify_no_data on datadog_monitor to false #11903

Merged
merged 1 commit into from
Feb 13, 2017

Commits on Feb 13, 2017

  1. provider/datadog: Default notify_no_data on datadog_monitor to false

    Fixes: #11863
    
    Backwards incompatible so will not be pushed to 0.8.x series. This
    follows the datadog documentation as mentioned in the issue
    
    ```
    % make testacc TEST=./builtin/providers/datadog TESTARGS='-run=TestAccDatadogMonitor_'
    ==> Checking that code complies with gofmt requirements...
    go generate $(go list ./... | grep -v /terraform/vendor/)
    2017/02/13 12:30:24 Generated command/internal_plugin_list.go
    TF_ACC=1 go test ./builtin/providers/datadog -v -run=TestAccDatadogMonitor_ -timeout 120m
    === RUN   TestAccDatadogMonitor_Basic
    --- PASS: TestAccDatadogMonitor_Basic (84.23s)
    === RUN   TestAccDatadogMonitor_BasicNoTreshold
    --- PASS: TestAccDatadogMonitor_BasicNoTreshold (81.92s)
    === RUN   TestAccDatadogMonitor_Updated
    --- PASS: TestAccDatadogMonitor_Updated (82.91s)
    === RUN   TestAccDatadogMonitor_TrimWhitespace
    --- PASS: TestAccDatadogMonitor_TrimWhitespace (63.34s)
    === RUN   TestAccDatadogMonitor_Basic_float_int
    --- PASS: TestAccDatadogMonitor_Basic_float_int (75.84s)
    PASS
    ok  	github.com/hashicorp/terraform/builtin/providers/datadog	388.257s
    ```
    stack72 committed Feb 13, 2017
    Configuration menu
    Copy the full SHA
    f1a704f View commit details
    Browse the repository at this point in the history