Computed values within nested object types in AssertPlanValid
#29482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation for nested object types with computed attributes was using the incorrect function call.
When using NestedMap objects, unify the codepath for both maps and objects as they may be interchangeable.
While blocks were not allowed to be computed by the provider, nested objects can be. Remove the errors regarding blocks and verify unknown values are valid.
jbardin
added
the
1.0-backport
apparentlymart
approved these changes
Aug 30, 2021
| @@ -1256,3 +1486,85 @@ func TestAssertPlanValid(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestAssertPlanValidTEST(t *testing.T) { | |||
There was a problem hiding this comment.
What does the "TEST" at the end of this function name represent? 🤔
There was a problem hiding this comment.
Oops, that was my temporary test harness for trying out values. I'll delete that before merging!
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for nested object attribute handling in
AssertPlanValid.Fixes #29473