Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed values within nested object types in AssertPlanValid #29482

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Computed values within nested object types in AssertPlanValid #29482

merged 4 commits into from
Aug 31, 2021

Commits on Aug 30, 2021

  1. correctly verify planned nested object values 

    The validation for nested object types with computed attributes was
using the incorrect function call.
    @jbardin
    jbardin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    7ca6be8 View commit details
    Browse the repository at this point in the history

  2. objects vs maps in nested object types 

    When using NestedMap objects, unify the codepath for both maps and
objects as they may be interchangeable.
    @jbardin
    jbardin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    9037970 View commit details
    Browse the repository at this point in the history

  3. nested object values can be computed 

    While blocks were not allowed to be computed by the provider, nested
objects can be. Remove the errors regarding blocks and verify unknown
values are valid.
    @jbardin
    jbardin committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    ea68d79 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. remove temp test

    @jbardin
    jbardin committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f195ce7 View commit details
    Browse the repository at this point in the history