objchange: fix ProposedNew from null objects #29701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codepath for
AllAttributesNull
was not correct for any nested objecttypes with collections, and should create single null values for the
correct NestingMode rather than a single object with null attributes.
Since there is no reason to descend into nested object types to create
null values, we can drop the
AllAttributesNull
function altogether andcreate null values as needed during
ProposedNew
.The corresponding
AllBlockAttributesNull
was only called internally in 1location, and simply delegated to
schema.EmptyValue
. We can reduce thepackage surface area by dropping that function too and calling
EmptyValue
directly.Fixes #29697