Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of objchange: fix ProposedNew from null objects into v1.0 #29704

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #29701 to be assessed for backporting due to the inclusion of the label 1.0-backport.

The below text is copied from the body of the original PR.


The codepath for AllAttributesNull was not correct for any nested object
types with collections, and should create single null values for the
correct NestingMode rather than a single object with null attributes.
Since there is no reason to descend into nested object types to create
null values, we can drop the AllAttributesNull function altogether and
create null values as needed during ProposedNew.

The corresponding AllBlockAttributesNull was only called internally in 1
location, and simply delegated to schema.EmptyValue. We can reduce the
package surface area by dropping that function too and calling
EmptyValue directly.

Fixes #29697

@teamterraform teamterraform force-pushed the backport/jbardin/proposed-new-null-objs/previously-infinite-midge branch from fe8b697 to c8fdc22 Compare October 5, 2021 17:10
@jbardin jbardin merged commit cd5271d into v1.0 Oct 5, 2021
@jbardin jbardin deleted the backport/jbardin/proposed-new-null-objs/previously-infinite-midge branch October 5, 2021 17:14
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants