Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements base64{enc,dec} interpolation funcs #3325

Merged
merged 1 commit into from
Oct 3, 2015
Merged

implements base64{enc,dec} interpolation funcs #3325

merged 1 commit into from
Oct 3, 2015

Conversation

glerchundi
Copy link
Contributor

fixes #3320

Signed-off-by: Gorka Lerchundi Osa [email protected]

@stack72
Copy link
Contributor

stack72 commented Sep 25, 2015

@glerchundi this looks very cool. I would love to see 1 of the acceptance tests updated to include an encrypted string just to see it in action :)

@apparentlymart
Copy link
Contributor

Thanks for working on this! 👍

@apparentlymart apparentlymart merged commit 70522fb into hashicorp:master Oct 3, 2015
@apparentlymart
Copy link
Contributor

I've merged this along with a follow-up commit c3d15a2 to add these functions to the interpolation docs. Thanks again!

@radeksimko
Copy link
Member

@apparentlymart Maybe a nitpick, but I still think it's worth asking before this reaches release - How about renaming these functions to base64encode and base64decode?

I have not seen enc or dec as a conventional abbreviations used anywhere, in fact dec could even evoke decimal.

@stack72
Copy link
Contributor

stack72 commented Oct 3, 2015

I'd love to see some examples of usage added to the examples repo

@apparentlymart
Copy link
Contributor

@radeksimko a fair point... also none of the other function names include abbreviated words. I think I agree with you. Shall I make a followup commit to fix this now, or do you think it's worth seeking other input first?

@radeksimko
Copy link
Member

@apparentlymart I think two maintainers in agreement should be enough 😉
Make a followup PR, I'll merge it.

@glerchundi
Copy link
Contributor Author

Cool, thanks! :)

@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: new built-in function base64(string)
4 participants