-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements base64{enc,dec} interpolation funcs #3325
Conversation
fixes #3320 Signed-off-by: Gorka Lerchundi Osa <[email protected]>
@glerchundi this looks very cool. I would love to see 1 of the acceptance tests updated to include an encrypted string just to see it in action :) |
Thanks for working on this! 👍 |
I've merged this along with a follow-up commit c3d15a2 to add these functions to the interpolation docs. Thanks again! |
@apparentlymart Maybe a nitpick, but I still think it's worth asking before this reaches release - How about renaming these functions to I have not seen |
I'd love to see some examples of usage added to the examples repo |
@radeksimko a fair point... also none of the other function names include abbreviated words. I think I agree with you. Shall I make a followup commit to fix this now, or do you think it's worth seeking other input first? |
@apparentlymart I think two maintainers in agreement should be enough 😉 |
Cool, thanks! :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
fixes #3320
Signed-off-by: Gorka Lerchundi Osa [email protected]