provider/aws: fix force_delete on ASGs #3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -414,6 +407,11 @@ func getAwsAutoscalingGroup( | |||
| func resourceAwsAutoscalingGroupDrain(d *schema.ResourceData, meta interface{}) error { | |||
| conn := meta.(*AWSClient).autoscalingconn | |||
|
|
|||
| if d.Get("force_delete").(bool) { | |||
| log.Printf("[DEBUG] Skipping ASG drain, force_delete was set.") | |||
There was a problem hiding this comment.
nitpick, force_delete may not have been set since it now has a default
There was a problem hiding this comment.
Not sure what you mean - it's true if we get to line 411. Is it just the log wording you'd like changed?
There was a problem hiding this comment.
nope, ignore me I misread that
phinze
force-pushed
the
b-aws-asg-force-delete
branch
from
5e87f5a
to
5338427
Compare
|
LGTM |
The `ForceDelete` parameter was getting sent to the upstream API call, but only after we had already finished draining instances from Terraform, so it was a moot point by then. This fixes that by skipping the drain when force_delete is true, and it also simplifies the field config a bit: * set a default of false to simplify the logic * remove `ForceNew` since there's no need to replace the resource to flip this value * pull a detail comment from code into the docs
phinze
force-pushed
the
b-aws-asg-force-delete
branch
from
5338427
to
a811a72
Compare
phinze
added a commit
that referenced
this pull request
Oct 12, 2015
provider/aws: fix force_delete on ASGs
|
I still seem to be getting blocked on ASG deletion: https://gist.github.com/maratoid/faa8262aed30400a69f2 Output: |
|
Thanks for testing @maratoid - reproduced locally and digging in... |
|
Much appreciated. |
|
BTW, should I open a tracking issue, or is the conversation in here sufficient? |
|
@maratoid turned into a bit of a rabbit hole - i will open a fresh issue 👍 🐰 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ForceDeleteparameter was getting sent to the upstream API call,but only after we had already finished draining instances from
Terraform, so it was a moot point by then.
This fixes that by skipping the drain when force_delete is true, and it
also simplifies the field config a bit:
ForceNewsince there's no need to replace the resource toflip this value