Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: fix force_delete on ASGs #3485

Merged
merged 1 commit into from
Oct 12, 2015
Merged

Commits on Oct 12, 2015

  1. provider/aws: fix force_delete on ASGs

    The `ForceDelete` parameter was getting sent to the upstream API call,
    but only after we had already finished draining instances from
    Terraform, so it was a moot point by then.
    
    This fixes that by skipping the drain when force_delete is true, and it
    also simplifies the field config a bit:
    
     * set a default of false to simplify the logic
     * remove `ForceNew` since there's no need to replace the resource to
       flip this value
     * pull a detail comment from code into the docs
    phinze committed Oct 12, 2015
    Configuration menu
    Copy the full SHA
    a811a72 View commit details
    Browse the repository at this point in the history