provider/aws: New Data Source: aws_acm_certificate #8359
Conversation
| func dataSourceAwsAcmCertificateRead(d *schema.ResourceData, meta interface{}) error { | ||
| conn := meta.(*AWSClient).acmconn | ||
| params := &acm.ListCertificatesInput{} | ||
| resp, err := conn.ListCertificates(params) |
There was a problem hiding this comment.
It looks like this API returns results in pages... do we need to handle NextToken in the response in order to see the whole list once a user has lots of certificates?
(Not clear to me whether not setting MaxItems in the request means "give me all of them" or "use the default limit"...)
There was a problem hiding this comment.
Ah yes I had meant to look into this... will dig.
|
Cool! I'll leave you and @apparentlymart to the review but this is a cool data source. |
Use this data source to get the ARN of a certificate in AWS Certificate Manager (ACM). The process of requesting and verifying a certificate in ACM requires some manual steps, which means that Terraform cannot automate the creation of ACM certificates. But using this data source, you can reference them by domain without having to hard code the ARNs as input. The acceptance test included requires an ACM certificate be pre-created in and information about it passed in via environment variables. It's a bit sad but there's really no other way to do it.
jen20
force-pushed
the
f-aws-acm-datasource
branch
2 times, most recently
from
f2a9b44
to
3ad4959
Compare
jen20
force-pushed
the
f-aws-acm-datasource
branch
from
3ad4959
to
3361047
Compare
|
Test Run: |
|
LGTM @jen20 - I can't approve via reviews since I was the original author lol |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Use this data source to get the ARN of a certificate in AWS Certificate
Manager (ACM). The process of requesting and verifying a certificate in ACM
requires some manual steps, which means that Terraform cannot automate the
creation of ACM certificates. But using this data source, you can reference
them by domain without having to hard code the ARNs as input.
The acceptance test included requires an ACM certificate be pre-created
in and information about it passed in via environment variables. It's a
bit sad but there's really no other way to do it.