-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: New Data Source: aws_acm_certificate #8359
Conversation
func dataSourceAwsAcmCertificateRead(d *schema.ResourceData, meta interface{}) error { | ||
conn := meta.(*AWSClient).acmconn | ||
params := &acm.ListCertificatesInput{} | ||
resp, err := conn.ListCertificates(params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this API returns results in pages... do we need to handle NextToken
in the response in order to see the whole list once a user has lots of certificates?
(Not clear to me whether not setting MaxItems
in the request means "give me all of them" or "use the default limit"...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I had meant to look into this... will dig.
Cool! I'll leave you and @apparentlymart to the review but this is a cool data source. |
Use this data source to get the ARN of a certificate in AWS Certificate Manager (ACM). The process of requesting and verifying a certificate in ACM requires some manual steps, which means that Terraform cannot automate the creation of ACM certificates. But using this data source, you can reference them by domain without having to hard code the ARNs as input. The acceptance test included requires an ACM certificate be pre-created in and information about it passed in via environment variables. It's a bit sad but there's really no other way to do it.
f2a9b44
to
3ad4959
Compare
3ad4959
to
3361047
Compare
Test Run:
|
LGTM @jen20 - I can't approve via reviews since I was the original author lol |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Use this data source to get the ARN of a certificate in AWS Certificate
Manager (ACM). The process of requesting and verifying a certificate in ACM
requires some manual steps, which means that Terraform cannot automate the
creation of ACM certificates. But using this data source, you can reference
them by domain without having to hard code the ARNs as input.
The acceptance test included requires an ACM certificate be pre-created
in and information about it passed in via environment variables. It's a
bit sad but there's really no other way to do it.