Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate old AWS_* variables #866

Closed
sethvargo opened this issue Jan 25, 2015 · 2 comments
Closed

Deprecate old AWS_* variables #866

sethvargo opened this issue Jan 25, 2015 · 2 comments
Labels
provider/aws

Comments

@sethvargo
Copy link
Contributor

See #851 for more information. The documentation is already updated, just need to print a nice deprecation warning when the old variables are used.
@sethvargo sethvargo mentioned this issue Jan 25, 2015
Merged
@radeksimko radeksimko mentioned this issue Feb 25, 2015
Closed
BRMatt added a commit to BRMatt/terraform that referenced this issue Mar 1, 2015
@BRMatt
Allow terraform to source AWS credentials from ~/.aws/credentials
40ec304 
This change also ensures that legacy env vars (AWS_ACCESS_KEY,
AWS_SECRET_KEY) have precedence over the official aws-cli variation, and
that both types of env var have precedence over settings in the
credentials file.

Note that this change technically supports different AWS credential
profiles via the AWS_PROFILE env variable. The goamz library handles
this.

see
 - hashicorp#266
 - hashicorp#866
@mitchellh
Copy link
Contributor

I'm actually going to say "let's just not do this" because deprecating and eventually removing will just cause pain to some users which is useless since its pretty harmless to support. As you said, its already documented, so no one will "learn" the old variables. I think that's good enough.

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
provider/aws
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchellh @sethvargo