Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/arukas: Fix broken build on windows #11140

Conversation

yamamoto-febc
Copy link
Contributor

This fixes the problem that the build broke on Windows by merging #10862.

@jbardin
Copy link
Member

jbardin commented Jan 11, 2017

Hi @yamamoto-febc,

Was this fixed upstream?

You can't patch a vendored package directly, since the next person who updates the vendor directory will revert the change. If it was fixed upstream, we ned to update the manifest so that the hash matches the correct revision.

@yamamoto-febc
Copy link
Contributor Author

Hi @jbardin,

Sorry , I don't seem to have understood the behavior of govendor.
Surely this method is not working well...

Since the original PR #10862 has been reverted, this PR's will also be included when re-issuing PullRequest, so please close this PR.

Regarding the case where the build on Windows has been broken, I will create another PullRequest which adds the Arukas provider, so let me discuss it there.

Thanks.

@yamamoto-febc
Copy link
Contributor Author

It closes because it corresponds with #11171

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants