provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go #1137

deverton · 2015-03-05T22:53:07Z

Add's support for managing VPN gateways in AWS. The way it works (and most of the code) is based on the way that internet gateways are currently handled. It's written using the aws-sdk-go library though.

Uses the aws-sdk-go module and is based on the way the existing aws_internet_gateway resource works.

deverton · 2015-03-06T05:49:37Z

One thing is I can't get the TestAccVpnGateway_tags acceptance test to pass and I'm not sure why it's not working. I get this error:

--- FAIL: TestAccVpnGateway_tags (118.38s)
    testing.go:121: Step 1 error: Error applying: 1 error(s) occurred:

        * 1 error(s) occurred:

        * 1 error(s) occurred:

        * The parameter Resources is not recognized

catsby · 2015-03-06T14:35:37Z

Hey @deverton thanks for the contribution!
I'll give this a better look-over today, initial glance looked good.

Regarding the acceptance test failure, I patched that issue in hashicorp/aws-sdk-go yesterday, can you run make updatedeps and try again? See hashicorp/aws-sdk-go#4 for the fix.

deverton · 2015-03-06T23:57:22Z

@catsby That patch has fixed the acceptance tests and everything now passes. Thanks!

catsby · 2015-03-09T19:46:41Z

Thanks! Taking a look now. I did notice that it needs go fmt ran on it, could you do that please?

catsby · 2015-03-09T19:59:32Z

builtin/providers/aws/resource_aws_vpn_gateway.go

+        VPCID:        aws.String(d.Get("vpc_id").(string)),
+    })
+    if err != nil {
+        ec2err, ok := err.(*aws.APIError)


If I'm not mistaken, the return here should be aws.APIError. Does the * work?

Not sure as I'm only just starting to learn Go. I'll take a closer look.

catsby · 2015-03-09T20:02:11Z

Looks promising, thanks! Pending some nitpicks and questions though, can you take a look @deverton ?

Current AWS documentation says there's only one type of VPN gateway for now.

AWS returns IncorrectState not DependencyViolation when a VPN gateway is still attached to a VPC.

deverton · 2015-03-10T00:35:29Z

Okay, I think all of the feedback has been applied.

catsby · 2015-03-11T21:41:30Z

@deverton excellent, thanks!

One final, super small nitpick that I missed: the VpnGatewayStateRefreshFunc is only used here, right? Let's make it private: vpnGatewayStateRefreshFunc (just lowercase it).

Let me know if you can get to that, otherwise I can merge and convert it.

Thanks again!

deverton · 2015-03-11T22:16:58Z

@catsby no problem, I've made that change.

deverton · 2015-03-19T01:16:57Z

@catsby I've updated the code to compile again after the goamz removal.

catsby · 2015-03-19T20:35:02Z

builtin/providers/aws/resource_aws_vpn_gateway.go

+func resourceAwsVpnGatewayRead(d *schema.ResourceData, meta interface{}) error {
+	ec2conn := meta.(*AWSClient).ec2conn
+
+	vpnGatewayRaw, _, err := vpnGatewayStateRefreshFunc(ec2conn, d.Id())()


Here you call a refresh func vpnGatewayStateRefreshFunc, but we only call it once and never try again, like in a wait.WaitForState in the resourceAwsVpnGatewayAttach function.

I see that's basically copied from Internet Gateway, so not a fault of yours 😄 . In your experience does this typically take time, and may fail on the first run?

catsby · 2015-03-19T20:35:23Z

I had another question, but I don't think it's a blocker.

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go

catsby · 2015-03-19T21:12:21Z

Going ahead an pulling this in, thanks @deverton !

ghost · 2020-05-04T01:54:16Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Dan Everton added 4 commits March 6, 2015 08:41

First pass at aws_vpn_gateway resource

e5a2504

Uses the aws-sdk-go module and is based on the way the existing aws_internet_gateway resource works.

Add acceptance test for aws_vpn_gateway resource.

4706ee7

Add documentation

b741e0c

Match the internet gateway code better.

98d827b

catsby added the provider/aws label Mar 5, 2015

Minor test fixes.

7240af4

Merge branch 'master' into aws-go-vpn

7565e69

catsby reviewed Mar 9, 2015
View reviewed changes

catsby added the waiting-response An issue/pull request is waiting for a response from the community label Mar 9, 2015

Dan Everton added 5 commits March 10, 2015 09:01

Merge branch 'master' into aws-go-vpn

3339ab9

Hardcode type parameter value.

d253fff

Current AWS documentation says there's only one type of VPN gateway for now.

Fix error handling.

c172fd3

AWS returns IncorrectState not DependencyViolation when a VPN gateway is still attached to a VPC.

Format the resource_vpn_gateway*.go files.

d6a7310

Remove type parameter from vpn_gateway docs

0900452

catsby removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 10, 2015

catsby added the waiting-response An issue/pull request is waiting for a response from the community label Mar 11, 2015

Dan Everton added 3 commits March 12, 2015 08:09

Merge branch 'master' into aws-go-vpn

9f50b04

Make vpnGatewayStateRefreshFunc private

cfd8d91

Update changelog.

7d5f7cb

catsby removed the waiting-response An issue/pull request is waiting for a response from the community label Mar 16, 2015

Merge branch 'master' into aws-go-vpn

f728959

Fixes for goamz removal.

8ebbaf5

catsby reviewed Mar 19, 2015
View reviewed changes

catsby added a commit that referenced this pull request Mar 19, 2015

Merge pull request #1137 from deverton/aws-go-vpn

bb4dd8a

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go

catsby merged commit bb4dd8a into hashicorp:master Mar 19, 2015

radeksimko mentioned this pull request Mar 25, 2015

AWS - tagging of resources #1296

Closed

7 tasks

ghost locked and limited conversation to collaborators May 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go #1137

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go #1137

deverton commented Mar 5, 2015

deverton commented Mar 6, 2015

catsby commented Mar 6, 2015

deverton commented Mar 6, 2015

catsby commented Mar 9, 2015

catsby Mar 9, 2015

deverton Mar 9, 2015

catsby commented Mar 9, 2015

deverton commented Mar 10, 2015

catsby commented Mar 11, 2015

deverton commented Mar 11, 2015

deverton commented Mar 19, 2015

catsby Mar 19, 2015

catsby commented Mar 19, 2015

catsby commented Mar 19, 2015

ghost commented May 4, 2020

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go #1137

provider/aws: Add Support For AWS VPN Gateways using aws-sdk-go #1137

Conversation

deverton commented Mar 5, 2015

deverton commented Mar 6, 2015

catsby commented Mar 6, 2015

deverton commented Mar 6, 2015

catsby commented Mar 9, 2015

catsby Mar 9, 2015

Choose a reason for hiding this comment

deverton Mar 9, 2015

Choose a reason for hiding this comment

catsby commented Mar 9, 2015

deverton commented Mar 10, 2015

catsby commented Mar 11, 2015

deverton commented Mar 11, 2015

deverton commented Mar 19, 2015

catsby Mar 19, 2015

Choose a reason for hiding this comment

catsby commented Mar 19, 2015

catsby commented Mar 19, 2015

ghost commented May 4, 2020