schema: Allow *Resource as Elem of TypeMap in validation #12722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
approved these changes
Mar 15, 2017
stack72
added a commit
that referenced
this pull request
Mar 15, 2017
)" This reverts commit 1df1c21.
stack72
added a commit
that referenced
this pull request
Mar 15, 2017
…12724) * Revert "datadog: Fix incorrect schema of monitor for 'silenced' (#12720)" This reverts commit 8730bf1. * Revert "schema: Allow *Resource as Elem of TypeMap in validation (#12722)" This reverts commit 1df1c21. * Revert "provider/alicloud: change create ecs postpaid instance API (#12226)" This reverts commit ffc5a06.
stack72
added a commit
that referenced
this pull request
Mar 15, 2017
…12724) * Revert "datadog: Fix incorrect schema of monitor for 'silenced' (#12720)" This reverts commit 8730bf1. * Revert "schema: Allow *Resource as Elem of TypeMap in validation (#12722)" This reverts commit 1df1c21. * Revert "provider/alicloud: change create ecs postpaid instance API (#12226)" This reverts commit ffc5a06.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #12638
I'm not overly happy about this PR as there's very likely a handful of resources actually genuinely broken due to the chosen schema, but as @jbardin mentioned we need to decide how are we going to handle nested structures and these resources will remain broken until then (unless someone fixes them by changing the schema & CRUD).
Depends on
#12720
#12721
Test plan