provider/aws: Fix issue with tainted ASG groups failing to re-create #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return resource.Retry(5*time.Minute, func() error { | ||
| if g, _ = getAwsAutoscalingGroup(d, meta); g != nil { | ||
| return fmt.Errorf("Auto Scaling Group still exists") | ||
| } |
There was a problem hiding this comment.
Should we check the error here and return a RetryError just so we're not waiting around 5m when the internet drops out?
There was a problem hiding this comment.
We discussed this just now and it's 👌 
There was a problem hiding this comment.
getAwsAutoscalingGroup only returns a non-nil g if it found the ASG, in which case we want to continue to pool
catsby
added a commit
that referenced
this pull request
Apr 1, 2015
provider/aws: Fix issue with tainted ASG groups failing to re-create
|
👍 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Scaling groups can take a minute or two to fully delete even after being drained. In the case of recreating them (ex. a tainted ASG), the immediate re-create attempt will fail because the original still exists, and the new one violates a name constraint.
This PR fixes #1105 by waiting on the ASG to fully delete before returning from the
resourceAwsAutoscalingGroupDeletefunction. The timeout is set at 5 minutes, but in practice it's usually less than 1 minute.