-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route 53 ALIAS Target Support #1366
Conversation
Running the acceptance tests locally right now. |
Sorry @jwaldrip - the 0.4.0 train is already on its way. The release cycle for 0.4.1 and 0.5.0 will be much faster, so this shouldn't have to hang out too long. |
Great. I was worried It was going to be another 6 months :-). |
Type: schema.TypeString, | ||
Required: true, | ||
ForceNew: true, | ||
Default: "${self.zone_id}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phinze any idea how I can reference another variable as the default if its not provided?
@phinze how does this implementation look? |
@catsby I know you have been thinking out this... But do you have any followup comments, or is this something you want to move forward with? |
Sorry for the lag there. Can we review why this is a separate resource, instead of along side a normal Route 53 Record resource? What are the hurdles to maintaining them as a single resource? |
Not so much a hurdle. Just some additional conditional logic. AWS handles this kind of strange, as ALIAS targets are somewhat of a sub resource of a record and invalidates many fields if enabled. Mainly, Alias targets conflict with the fields "TTL" and "records". We could make it work, but they were "different enough" in my mind to separate them. |
Sorry for the pain here @jwaldrip – we've actually since migrated back to https://github.com/awslabs/aws-sdk-go from our fork for the AWS library, can you swap that library out? It's preventing the tests from passing 😦 Let me know if you have questions on that or can't get to it, I can try and get to it this week |
Good news! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
@mitchellh I was hoping I could sneak this into 0.4.0 as well. Any chance we could make that happen?