Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route 53 ALIAS Target Support #1366

Closed
wants to merge 6 commits into from
Closed

Route 53 ALIAS Target Support #1366

wants to merge 6 commits into from

Conversation

jwaldrip
Copy link
Contributor

@jwaldrip jwaldrip commented Apr 2, 2015

@mitchellh I was hoping I could sneak this into 0.4.0 as well. Any chance we could make that happen?

@jwaldrip
Copy link
Contributor Author

jwaldrip commented Apr 2, 2015

Running the acceptance tests locally right now.

@jwaldrip jwaldrip changed the title Route 53 ALIAS Record Support Route 53 ALIAS Target Support Apr 2, 2015
@phinze
Copy link
Contributor

phinze commented Apr 2, 2015

Sorry @jwaldrip - the 0.4.0 train is already on its way. The release cycle for 0.4.1 and 0.5.0 will be much faster, so this shouldn't have to hang out too long.

@jwaldrip
Copy link
Contributor Author

jwaldrip commented Apr 2, 2015

Great. I was worried It was going to be another 6 months :-).

Type: schema.TypeString,
Required: true,
ForceNew: true,
Default: "${self.zone_id}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phinze any idea how I can reference another variable as the default if its not provided?

@jwaldrip
Copy link
Contributor Author

jwaldrip commented Apr 8, 2015

@phinze how does this implementation look?

@jwaldrip
Copy link
Contributor Author

@catsby I know you have been thinking out this... But do you have any followup comments, or is this something you want to move forward with?

@catsby
Copy link
Contributor

catsby commented Apr 29, 2015

Sorry for the lag there. Can we review why this is a separate resource, instead of along side a normal Route 53 Record resource? What are the hurdles to maintaining them as a single resource?

@catsby catsby added the waiting-response An issue/pull request is waiting for a response from the community label Apr 29, 2015
@jwaldrip
Copy link
Contributor Author

Not so much a hurdle. Just some additional conditional logic. AWS handles this kind of strange, as ALIAS targets are somewhat of a sub resource of a record and invalidates many fields if enabled. Mainly, Alias targets conflict with the fields "TTL" and "records". We could make it work, but they were "different enough" in my mind to separate them.

@catsby
Copy link
Contributor

catsby commented May 4, 2015

Sorry for the pain here @jwaldrip – we've actually since migrated back to https://github.com/awslabs/aws-sdk-go from our fork for the AWS library, can you swap that library out? It's preventing the tests from passing 😦

Let me know if you have questions on that or can't get to it, I can try and get to it this week

@radeksimko
Copy link
Member

@catsby see #1775

@mitchellh
Copy link
Contributor

Lets go with #1775 due to the refactor. Sorry for the delay @jwaldrip but this will get into 0.5! :)

@mitchellh mitchellh closed this May 4, 2015
@jwaldrip
Copy link
Contributor Author

jwaldrip commented May 4, 2015

Good news!

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants