providers/aws: aws_eip should not provide an empty PublicIp for describe calls

[pmoust]

When querying an EIP in VPC scope, PublicIp should not be provided in request or it yields;

* Error retrieving EIP: InvalidParameterValue: Invalid value '' for PublicIp. Not a valid IPv4 address.

Quite likely the acceptance tests will need an update as well.

[radeksimko]

👍 I'm hitting this issue as well and I've done some debugging too.
IMO anyone who doesn't have EC2 Classic account must be hitting this issue.

I believe this needs to be fixed in resourceAwsEipUpdate as well, feel free to pick up my changes or I can pick up yours and create a new PR (don't want to take your credit 😸 ):

master...TimeIncOSS:fix-eip-describe

I took the liberty and cherry-picked your fixes for acceptance tests - works like a charm! 👍

---

There's another issue I found (when no IGW defined) and fixed in that branch, so I may send a patch for that separately.

[pmoust]

Feel free, your syntax is more idiomatic.

[radeksimko]

@pmoust Thanks, done: #1598

[pmoust]

Closing in favor of #1598

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.