provider/aws: Fix issue with updating VPC Security Group IDs for an Instance #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assocIds := []*string{} | ||
| publicIps := []*string{} | ||
| var publicIps []*string | ||
| var assocIds []*string |
There was a problem hiding this comment.
The test was failing to create the EIP because of this. While this fixes this particular acceptance test, #1598 may be a better solution long term
|
This fixes the issue for me 👍 |
|
Working fine for us as well. |
|
works great for me 👍 |
…nstance Currently, we weren't correctly setting the ids, and are setting both `security_groups` and `vpc_security_group_ids`. As a result, we really only use the former. We also don't actually update the latter in the `update` method. This PR fixes both issues, correctly reading `security_groups` vs. `vpc_security_group_ids` and allows users to update the latter without destroying the Instance when in a VPC.
catsby
force-pushed
the
b-aws-fix-vpc-security-id-update
branch
from
e79c5f1
to
036d199
Compare
|
LGTM! |
catsby
added a commit
that referenced
this pull request
Apr 29, 2015
provider/aws: Fix issue with updating VPC Security Group IDs for an Instance
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we aren't correctly setting the ids, and are setting both
security_groupsandvpc_security_group_idsin the state. As a result, we really only usethe former, but the latter never goes away in the state file 😦
We also don't actually update the remote security groups in the
updatemethod.This PR fixes both issues, correctly reading
security_groupsvs.vpc_security_group_idsand allows users to update the latter withoutdestroying the Instance when in a VPC.
Should fix #1611