Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A partial fix the "-1" protocol problem in AWS security groups #1798

Merged
merged 4 commits into from
May 7, 2015
Merged

A partial fix the "-1" protocol problem in AWS security groups #1798

merged 4 commits into from
May 7, 2015

Commits on May 5, 2015

  1. aws: error on expndIPPerms(...) if our ports and protocol conflict. 

    Ingress and egress rules given a "-1" protocol don't have ports when
Read out of AWS. This results in hashing problems, as a local
config file might contain port declarations AWS can't ever return.

Rather than making ports optional fields, which carries with it a huge
headache trying to distinguish between zero-value attributes (e.g.
'to_port = 0') and attributes that are simply omitted, simply force the
user to opt-in when using the "-1" protocol. If they choose to use it,
they must now specify "0" for both to_port and from_port. Any other
configuration will error.
    @ctiwald
    ctiwald committed May 5, 2015
    Configuration menu
    Copy the full SHA
    89bacc0 View commit details
    Browse the repository at this point in the history

  2. aws: Add security group acceptance tests for protocol -1 fixes. 

    These only test ingress rules as egress rules are broken by the
default "0.0.0.0/0" rule Amazon includes with every egressed security
group.
    @ctiwald
    ctiwald committed May 5, 2015
    Configuration menu
    Copy the full SHA
    362a612 View commit details
    Browse the repository at this point in the history

  3. aws: Fixup structure_test to handle new expandIPPerms behavior.

    @ctiwald
    ctiwald committed May 5, 2015
    Configuration menu
    Copy the full SHA
    69e981c View commit details
    Browse the repository at this point in the history

  4. aws: Document the odd protocol = "-1" behavior in security groups.

    @ctiwald
    ctiwald committed May 5, 2015
    Configuration menu
    Copy the full SHA
    2526379 View commit details
    Browse the repository at this point in the history