remote/backend/swift: Add support for workspaces #18378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yanndegat
commented
Jul 3, 2018
yanndegat
commented
- add support for workspaces in remote backend swift
- fix failing acc tests
|
ping @jtopjian |
jtopjian
reviewed
Jul 3, 2018
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
From what I can tell, there's no new error being generated between here and line 30, so can this be removed?
|
Solid 👍 from me aswell... Workspace support was always something I meant to loop back round to, but never found the time... |
yanndegat
force-pushed
the
swift_workspaces_support2
branch
from
5210417
to
8cee67e
Compare
yanndegat
force-pushed
the
swift_workspaces_support2
branch
2 times, most recently
from
7ddffe7
to
c321c94
Compare
- add support for workspaces in remote backend swift - fix failing acc tests
yanndegat
force-pushed
the
swift_workspaces_support2
branch
from
c321c94
to
be3a6b7
Compare
|
|
|
closing in favor of #20211 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.