Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift backend: add application credential support #20914

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Apr 3, 2019

This PR adds an application credential auth support to the swift backend. Application credentials auth is already supported by an openstack provider. See https://github.com/terraform-providers/terraform-provider-openstack/pull/642

/cc @jtopjian , @jbardin

@kayrus
Copy link
Contributor Author

kayrus commented Apr 16, 2019

cc @radeksimko. I hope you'll find time to review this PR

Copy link
Contributor

@jtopjian jtopjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The functionality is equivalent to the OpenStack provider which has been confirmed to work.

@pselle
Copy link
Contributor

pselle commented Apr 17, 2019

@kayrus Thanks so much for this contribution -- it generally looks good, but at present Terraform is feature-frozen pending the 0.12 release. Again, thank you, and appreciate the contribution, and looking forward to getting to it after 0.12.

@pselle pselle added this to the v0.12.1 milestone Apr 17, 2019
@kayrus
Copy link
Contributor Author

kayrus commented Apr 17, 2019

@pselle I'm afraid that users will be confused using application credentials auth along with the swift backend. They will observe that Openstack provider works fine, but not the backend.

@pselle pselle modified the milestones: v0.12.1, TBD Jun 4, 2019
@kayrus
Copy link
Contributor Author

kayrus commented Jun 12, 2019

rebased on top of #18671
@apparentlymart, please review

@pselle pselle merged commit 444a7eb into hashicorp:master Jun 12, 2019
@kayrus kayrus deleted the swift-app-creds branch June 12, 2019 18:35
@ghost
Copy link

ghost commented Jul 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants