implement addrs.ConfigResource #24362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sdkv1
Remove unused variables, sync.Once, and init in BuiltinEvalContext. Replace some shim calls. GraphNodeAttachProvider doesn't need to be a NodeModuleInstance.
jbardin
force-pushed
the
jbardin/module-expansion-some-more
branch
from
f50a0c1
to
6da0b1c
Compare
Core needs a way to address resources through unexpanded modules, as they are present in the configuration. There are already some cases of paring `addrs.Module` with `addrs.Resource` for this purpose, but it is going to be helpful to have a single type to describe that pair, as well as have the ability to use TargetContains.
jbardin
force-pushed
the
jbardin/module-expansion-some-more
branch
from
6da0b1c
to
d65bd64
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core needs a way to address resources through unexpanded modules, as
they are present in the configuration. There are already some cases of
paring
addrs.Modulewithaddrs.Resourcefor this purpose, but it isgoing to be helpful to have a single type to describe that pair, as
well as have the ability to use TargetContains.