Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for swift authentication #24786

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

danieldreier
Copy link
Contributor

@kayrus and @jtopjian I wanted to get a quick review here from you. I read the docs updates in GH-23510 and it wasn't clear to me whether user will need to make changes to their configuration or if this is purely additive. If they do need to make changes I'd like to list it as a breaking change, otherwise I think it should be categorized as an enhancement.

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #24786 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
terraform/evaluate.go 46.86% <0.00%> (+0.60%) ⬆️

@jtopjian
Copy link
Contributor

I reviewed the changes being made in backend.go of #23510 a few times before I made my comment and I'm fairly confident that the user does not need to make any changes - items were shuffled around and some new optional parameters were added. What you've added to the CHANGELOG here sounds correct.

But let's wait for @kayrus to confirm just in case I missed something. I feel like I'm being over-cautious, but that never hurts.

@kayrus
Copy link
Contributor

kayrus commented Apr 28, 2020

@jtopjian thanks for your comment. @danieldreier this is correct. I just synced the auth logic with the terraform provider auth logic. There are no breaking changes which force users to change configuration.

@danieldreier danieldreier merged commit c5a2e27 into master Apr 28, 2020
@danieldreier danieldreier deleted the danieldreier-23510-changelog branch April 28, 2020 16:04
@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants