Hide empty plans for misbehaving data resource #25302
Conversation
If a data source is storing a value that doesn't comply precisely with the schema, it will now show up as a perpetual diff during plan. Since we can easily detect if there is no resulting change from the stored value, rather than presenting a planned read each time, we can change the plan to a NoOp and log the incongruity as a warning.
Codecov Report
|
There was a problem hiding this comment.
This makes sense to me!
It seems like there isn't really any reasonable path to upgrade this from a warning to an error because adding a new opt-out flag like we did for resources would fail for providers that don't know how to set it, and adding an "opt in to Terraform being stricter" is not a useful design either. That's a shame, but I don't have any other ideas to suggest, so I guess we'll just need to keep an eye out for opportunities to make other breaking changes to this particular provider API in future and bundle stricter error checking along with it.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
If a data source is storing a value that doesn't comply precisely with
the schema, it will now show up as a perpetual diff during plan. We
don't have a strict check for this, as data sources do not have the
LegacyTypeSystemflag to allow this behavior, but we can use thesame verification we use for managed resources.
Since we can easily detect if there is no resulting change from the
stored value, rather than presenting a planned read each time, we can
change the plan to a NoOp and log the incongruity as a warning.
Fixes #25179, at least from the core side. Any other unexplained plans
would need to be fixed in the provider.