-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go vet as a check to the Github commit actions #31461
Conversation
scripts/govetcheck.sh
Outdated
if [[ -n ${govet_out} ]]; then | ||
echo "go vet has discovered the following issues" | ||
echo "${govet_out}" | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this script? I think go vet
exits 1 if it finds anything anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right we don't need the script. Although the exit code from go vet
is 2, but I don't think that matters?
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Follow up from #31432
In this case we run
go vet
over the entire code base, because we are actually up to date (only 7 findings all of which are fixed in this PR).