Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go vet as a check to the Github commit actions #31461

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Jul 18, 2022

Follow up from #31432

In this case we run go vet over the entire code base, because we are actually up to date (only 7 findings all of which are fixed in this PR).

@liamcervante liamcervante requested a review from a team July 18, 2022 16:17
if [[ -n ${govet_out} ]]; then
echo "go vet has discovered the following issues"
echo "${govet_out}"
exit 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this script? I think go vet exits 1 if it finds anything anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right we don't need the script. Although the exit code from go vet is 2, but I don't think that matters?

@liamcervante liamcervante requested review from a team and removed request for kmoe November 7, 2024 16:15
@liamcervante liamcervante merged commit eeacced into main Nov 7, 2024
7 checks passed
@liamcervante liamcervante deleted the liamcervante/cicd-go-vet branch November 7, 2024 16:30
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants