provider/aws: KMS WIP #3209
provider/aws: KMS WIP #3209
Conversation
|
@psytale Sorry for the silence here, would you mind incorporating the deletion into the PR and solving conflicts that have accumulated over the time? 😉 |
|
I want to know what is missing for this feature to reach release? |
|
Sorry for the silence @psytale and @Felivel – In order to merge this we'll need to add acceptance tests, to ensure things work and continue to work going forward. Any chance you'd be willing to add those? If you have questions on how to proceed, you can ask here, otherwise I would simply copy over an existing Let me know if you have any questions! |
catsby
added
the
waiting-response
|
I just noticed #3928 which seems to be a continuation of this PR in spirit, can we close this PR then? |
|
Closed in favor of #3928 |
|
Thanks @psytale ! |
* Update gcp auth backend docs * Minor formatting and wording fixes * Minor formatting fixes
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Currently only supporting Keys + Aliases, could add more but looking for a bit of feedback to ensure I'm on the right path.
Tests need writing but a bit unsure, main concern is that KMS keys can not be deleted only deactivated in addition there is a limit to total number of keys per account, so the idea of adding them in acceptance tests is a bit scary.