Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing Framework] Add test command to Terraform CLI #33327

Merged
merged 10 commits into from
Jun 28, 2023

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Jun 7, 2023

This PR adds the test command back into Terraform, and connects all the previous PRs into a functional testing framework.

Target Release

1.6.0

Terraform Testing Framework

This PR is part of a chain of PRs implementing the new Terraform test command.

Description Branch PR
Cleanup previous implementation liamcervante/tests/cleanup #33323
Add initial human view implementation liamcervante/tests/view #33324
Add Terraform test file config support liamcervante/tests/config #33325
Update terraform context functionality liamcervante/tests/context #33326
Add test command to Terraform CLI liamcervante/tests/command #33327

The above PRs implement the core functionality of the new test command. More PRs will follow implementing specific features, but the test command will work end-to-end once the above PRs are merged.

These changes are implemented in a chain, with each change building on the previous one to ensure ease of review. To see the combined changes as one, navigate to the last PR in the chain and change it to merge directly into main.

Base automatically changed from liamcervante/tests/context to main June 26, 2023 15:42
Copy link
Member

@jbardin jbardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to get the command into a usable state for additional testing. If test is not going to make use of the local backend for running plans and applies, we are going to need to make sure some of that framework gets replicated within the test command. Plugin validation and process cancelation are the first to things that come to mind.

@liamcervante liamcervante merged commit dfc26c2 into main Jun 28, 2023
4 checks passed
@liamcervante liamcervante deleted the liamcervante/tests/command branch June 28, 2023 07:37
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants