testing framework: refactor interrupt logic for immediate exits #33532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamcervante
force-pushed
the
liamcervante/tests/interrupts
branch
from
f1ff89e
to
9a637ca
Compare
jbardin
approved these changes
Jul 18, 2023
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the interrupt logic within the Terraform test framework.
Previously, it always finished the current execution so that it could print out the existing infrastructure so that this data wasn't lost. This meant that a stuck operation would never finish, but it was safe from the perspective of data loss being captured.
This PR modifies the interrupt logic so that it skips all cleanup, and prints out the relevant information immediately. It also introduces a 5 second timeout after a fatal interrupt so that users can always exit a test operation. This is safe now that Terraform will print out the relevant information immediately, instead of waiting for the current operation to finish.