Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: create_before_destroy meta-attribute propagation into v1.5 #33580

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #32279 to be assessed for backporting due to the inclusion of the label 1.5-backport.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


I've spent quite a lot of time to figure out the fact create_before_destroy meta-attribute propagates to all dependencies. Seems like I was not the only one who found this non-intuitive (GitHub issue). I think it's worth noting this behaviour in the documentation explicitly. I don't mind changing the text by maintainers if there is a better English variant.

Explains: hashicorp/terraform-provider-kubernetes#1906

CHANGELOG

  • Document create_before_destroy meta-attribute propagation behaviour

@teamterraform teamterraform force-pushed the backport/doc-create-before-destroy-propagation/exactly-finer-seagull branch 4 times, most recently from 8405d30 to 2d22ce3 Compare July 25, 2023 22:12
@crw crw merged commit b60a22a into v1.5 Jul 25, 2023
4 checks passed
@crw crw deleted the backport/doc-create-before-destroy-propagation/exactly-finer-seagull branch July 25, 2023 22:28
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants