Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/s3: Adds singleNestedAttribute to internal schema #33872

Merged
merged 4 commits into from
Sep 13, 2023
Merged

backend/s3: Adds singleNestedAttribute to internal schema #33872

merged 4 commits into from
Sep 13, 2023

Conversation

gdavison
Copy link
Contributor

Updates internal schema to include singleNestedAttribute type and updates backend schema to use it for nested attributes.

Target Release

1.6.0

Draft CHANGELOG entry

No user facing change

@gdavison gdavison added backend/s3 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged labels Sep 11, 2023
@gdavison gdavison requested a review from a team as a code owner September 11, 2023 22:22
jar-b
jar-b approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 112.093s

internal/backend/remote-state/s3/backend.go Outdated Show resolved Hide resolved
@gdavison gdavison merged commit 9437c43 into main Sep 13, 2023
4 checks passed
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@teamterraform teamterraform mentioned this pull request Sep 13, 2023
Merged
@jar-b jar-b mentioned this pull request Sep 15, 2023
Merged
@teamterraform teamterraform mentioned this pull request Sep 19, 2023
Merged
@gdavison gdavison deleted the s3/f-schema-single-nested-object branch October 24, 2023 19:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b