-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support for ssh over SOCKS5 #33969
Conversation
Fixes hashicorp#17754, surprisingly. `golang.org/x/net/proxy.FromURL` (which Terraform uses to add support for HTTP and HTTPS) supports socks5 out of the box: https://cs.opensource.google/go/x/net/+/refs/tags/v0.15.0:proxy/proxy.go;l=91
@sorenisanerd is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
Thanks @sorenisanerd for this update and spotting that this functionality now exists. I plan to bring this to triage and hopefully get it reviewed, would you please sign the CLA so that we can use this submission? Thanks again! |
Hi @sorenisanerd, we would be happy to approve these changes once you sign the CLA. Once you have done that, I'll let the docs team do a once-over on the style and we will be set. Thanks! |
Also, I wonder if it is worth updating to mention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this - just a few edits for consistency with our styles
Hi @sorenisanerd, the next steps for this PR are to accept the CLA and the accept changes proposed above or discuss the changes. Thanks! |
Yep, still working on the CLA.
… Message ID: ***@***.***>
|
@crw, I signed the CLA. Apologies for the delay. |
@sorenisanerd thank you! The next and potentially final step is to accept the suggested changes above, or discuss the changes if you disagree with them. Thanks! |
Co-authored-by: trujillo-adam <[email protected]>
Done-diddly-done. |
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #17754, surprisingly.
golang.org/x/net/proxy.FromURL
(which Terraform uses to add support for HTTP and HTTPS) supports socks5 out of the box:https://cs.opensource.google/go/x/net/+/refs/tags/v0.15.0:proxy/proxy.go;l=91