Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support for ssh over SOCKS5 #33969

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

sorenisanerd
Copy link
Contributor

Fixes #17754, surprisingly.

golang.org/x/net/proxy.FromURL (which Terraform uses to add support for HTTP and HTTPS) supports socks5 out of the box:

https://cs.opensource.google/go/x/net/+/refs/tags/v0.15.0:proxy/proxy.go;l=91

Fixes hashicorp#17754, surprisingly.

`golang.org/x/net/proxy.FromURL` (which Terraform uses to add support for HTTP and HTTPS) supports socks5 out of the box:

https://cs.opensource.google/go/x/net/+/refs/tags/v0.15.0:proxy/proxy.go;l=91
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Oct 3, 2023

@sorenisanerd is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@crw
Copy link
Collaborator

crw commented Oct 3, 2023

Thanks @sorenisanerd for this update and spotting that this functionality now exists. I plan to bring this to triage and hopefully get it reviewed, would you please sign the CLA so that we can use this submission? Thanks again!

@crw crw mentioned this pull request Oct 5, 2023
@crw
Copy link
Collaborator

crw commented Oct 6, 2023

Hi @sorenisanerd, we would be happy to approve these changes once you sign the CLA. Once you have done that, I'll let the docs team do a once-over on the style and we will be set. Thanks!

@crw crw added the waiting-response An issue/pull request is waiting for a response from the community label Oct 6, 2023
@crw
Copy link
Collaborator

crw commented Oct 6, 2023

Also, I wonder if it is worth updating to mention socks5h support? To be honest, I am not clear if that is fully supported by the new functionality or just recognized as a keyword that defaults to some more basic socks5 functionality (just because it is caught by the same case statement in that code snippet, above). I leave it to your judgement. Thanks!

Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - just a few edits for consistency with our styles

@crw
Copy link
Collaborator

crw commented Nov 17, 2023

Hi @sorenisanerd, the next steps for this PR are to accept the CLA and the accept changes proposed above or discuss the changes. Thanks!

@sorenisanerd
Copy link
Contributor Author

sorenisanerd commented Nov 20, 2023 via email

@sorenisanerd
Copy link
Contributor Author

@crw, I signed the CLA. Apologies for the delay.

@crw
Copy link
Collaborator

crw commented Feb 26, 2024

@sorenisanerd thank you! The next and potentially final step is to accept the suggested changes above, or discuss the changes if you disagree with them. Thanks!

@sorenisanerd
Copy link
Contributor Author

Done-diddly-done.

@crw crw added 1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed waiting-response An issue/pull request is waiting for a response from the community labels Feb 27, 2024
@crw crw merged commit 42aa821 into hashicorp:main Feb 27, 2024
6 of 7 checks passed
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.7-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socks5 proxy support
4 participants