stacks: ensure that all components in state are referenced in configuration #35677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
approved these changes
Sep 6, 2024
Base automatically changed from
liamcervante/stacks/removed-functionality
to
main
September 7, 2024 12:36
…nent or resource block
liamcervante
force-pushed
the
liamcervante/stacks/removed-state-validation
branch
from
d164c17
to
a90ffd7
Compare
liamcervante
deleted the
liamcervante/stacks/removed-state-validation
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the root Stack object such that it will add diagnostics if it discovers any components within state that are not referenced by a component or a removed block. This ensures that users don't think they are deleting resources by removing a component block and forgetting to add a removed block.