Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version-constraints.mdx #35699

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update version-constraints.mdx #35699

merged 2 commits into from
Sep 10, 2024

Conversation

jnesta-lh
Copy link
Contributor

npm is supposed to be lowercase, so this is a bug in the docs. I fixed this bug and decided to linkify it for good measure.

@hashicorp-cla-app HashiCorp CLA App
Copy link

hashicorp-cla-app bot commented Sep 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

crw
crw requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@crw crw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we'd prefer not to add links for various reasons. If you would like to resubmit with just the lowercasing of npm, I'd accept it. Thanks!

@crw crw added waiting-response An issue/pull request is waiting for a response from the community documentation labels Sep 9, 2024
@jnesta-lh
Copy link
Contributor Author

done

@crw crw added 1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed waiting-response An issue/pull request is waiting for a response from the community labels Sep 10, 2024
@crw crw merged commit c0ba868 into hashicorp:main Sep 10, 2024
6 of 7 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Merged
@jnesta-lh jnesta-lh deleted the patch-1 branch September 11, 2024 08:31
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crw crw crw approved these changes

Assignees
No one assigned
Labels
1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnesta-lh @crw