core: ephemeral resources #35764
core: ephemeral resources #35764
Conversation
Implement the core nodes for ephemeral resources. This constitutes what's needed for execution, but does not yet include all the necessary graph transformations.
There's still some duplicated code in here, we'll try and sort that out in a later refactor. Ephemeral resources are not currently working with deferrals.
TODOs: - deferrals (still) - The prune transformer needs to take care of ephemerals too in order to continue partial destroys - ValidateEphemeralResourceConfig is not yet called during validate walk.
Call ValidateEphemeralResourcConfig during validation walk. Found that marks don't show up during validation, which may be an HCL bug
| // First, we're going to load any instances that we have written into the | ||
| // deferrals system. A deferred resource overrides anything that might be | ||
| // in the state for the resource, so we do this first. | ||
| for key, value := range d.Evaluator.Deferrals.GetDeferredResourceInstances(addr.Absolute(d.ModulePath)) { |
There was a problem hiding this comment.
I think we would run into an issue here since the ephemeral resource mode is not supported by the deferrals package. Or is that what you referred to in the description that deferrals are not accounted for?
There was a problem hiding this comment.
yeah, this function was taken directly from the original POC. I have not considered deferrals yet in any way, so it's not expected to work at all if they are active.
| @@ -213,6 +214,9 @@ func (n *nodeCloseModule) Execute(ctx EvalContext, op walkOperation) (diags tfdi | |||
| // any running plugins | |||
| diags = diags.Append(ctx.ClosePlugins()) | |||
|
|
|||
| // We also close up the ephemeral resource manager | |||
| diags = diags.Append(ctx.EphemeralResources().Close(context.TODO())) | |||
There was a problem hiding this comment.
With context.TODO() we won't be able to cancel the close calls, right? Is that intended?
There was a problem hiding this comment.
Yeah, I'll have a followup to connect the cancelation context with ephemeral resources. Because this still has some of the original architecture that predates the context package, they were never connected here. (plugins sort of get the context through a side-channel rather than inline in each rpc call)
Includes a fix for this PR, we will update to a tagged version before release.
|
Since the hcl fix was merged first, I updated this PR to use the latest hcl commit rather than work around the evaluation bugs. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Enable the use of ephemeral resources is Terraform core.
One step closer to supporting ephemeral resources, this adds the core support implementation, and connects a lot of the individual pieces needed for evaluation.
A few key points which we can address separately are