Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Support scratch volumes in ecs_task_definition #3810

Merged
merged 1 commit into from
Nov 10, 2015
Merged

provider/aws: Support scratch volumes in ecs_task_definition #3810

merged 1 commit into from
Nov 10, 2015

Conversation

radeksimko
Copy link
Member

Fixes #2370

Originally terraform was constructing the struct with sourcePath being empty string (when not defined in the DSL) which was causing API error.

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=EcsTaskDefinition' 2>~/tf.log

go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=EcsTaskDefinition -timeout 90m
=== RUN   TestAccAWSEcsTaskDefinition_basic
--- PASS: TestAccAWSEcsTaskDefinition_basic (22.38s)
=== RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
--- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (12.00s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    34.399s

@radeksimko radeksimko mentioned this pull request Nov 8, 2015
Closed
@catsby
Copy link
Contributor

catsby commented Nov 10, 2015

LGTM!

radeksimko added a commit that referenced this pull request Nov 10, 2015
@radeksimko
Merge pull request #3810 from TimeIncOSS/f-aws-ecs-ephemeral-volumes
ac6efd8 
provider/aws: Support scratch volumes in ecs_task_definition
@radeksimko radeksimko merged commit ac6efd8 into hashicorp:master Nov 10, 2015
@radeksimko radeksimko deleted the f-aws-ecs-ephemeral-volumes branch November 10, 2015 23:22
xoob added a commit to xoob/terraform that referenced this pull request Dec 12, 2016
@xoob
Document ECS scratch volumes
c22677e 
Update docs to say that volumes can be created without host_path, which will create an nonpersistent volume, as per http://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_data_volumes.html.

This feature was implemented in hashicorp#3810 but did not appear in the docs.
@xoob xoob mentioned this pull request Dec 12, 2016
Merged
stack72 pushed a commit that referenced this pull request Dec 12, 2016
@xoob @stack72
Document ECS scratch volumes (#10683)
c1637f2 
Update docs to say that volumes can be created without host_path, which will create an nonpersistent volume, as per http://docs.aws.amazon.com/AmazonECS/latest/developerguide/using_data_volumes.html.

This feature was implemented in #3810 but did not appear in the docs.
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provider/aws: Support ephemeral volumes in ecs_task_definition
2 participants
@radeksimko @catsby