provider/template: Clouding provider headers

[sthulb]

Adds headers to the parts and MIME-Version to the overall document.

So, it appears that mime/multipart has some issues: https://golang.org/src/mime/multipart/writer.go#L97

Because it doesn't sort headers before writing them, they could end up out of order, this would mean the diff could change.

[jen20]

Hi @sthulb, any reason that the tests are removed?

[sthulb]

I've actually added them back locally.

I've forked the mime/multipart package to sort part headers, something being merged in to go for 1.7 with my patch.

I'll write a better summary when I'm back on my laptop.

On 7 Dec 2015, at 17:51, James Nugent [email protected] wrote:

Hi @sthulb, any reason that the tests are removed?

—
Reply to this email directly or view it on GitHub.

[sthulb]

It turns out that go doesn't sort MIMEHeaders before writing them, so this obviously breaks terraform since terraform relied on diffs if resources being the same all of the time.

I've made a patch and I'll submit it tomorrow morning/tonight to Go for their 1.7 release (sometime in Feb). In the mean time, I'll keep a fork of the mime/multipart package for terraform with my patch in.

Go issue: golang/go#13522

[sthulb]

Gerrit patch: https://go-review.googlesource.com/#/c/17497/

[sthulb]

@jen20 I'd consider this complete now. :)

[jen20]

@sthulb That change makes sense - hopefully it will make it into the next release of Go. In the meantime using your fork with the same changeset seems fine to me. I'll merge this into the feature branch in the HashiCorp repo, and we can review from there! Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.