Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the OpsWorks cookbooks SSH key write only #4241

Merged

Conversation

b-ryan
Copy link
Contributor

@b-ryan b-ryan commented Dec 9, 2015

Fixes #3635

This follows the suggestion of @apparentlymart in
#3635 (comment)
to fix the issue of OpsWorks stacks always complaining about the custom
cookbooks SSH key needing to be changed.

Functional tests:

  • Created a new stack and gave it an SSH key. The key was written to
    OpsWorks properly.
  • Ran "plan" again and terraform indicated it needed to change the SSH
    key, which is expected since terraform cannot read what the existing
    SSH is.
  • Removed the key from my resource and this time, "plan" did not have
    any changes. The tfstate file indicated the SSH key was "" (empty
    string).
  • Changed an unrelated property of the stack. Previously this was not
    working for me due to terraform attempting to change the SSH key.

Fixes hashicorp#3635

This follows the suggestion of @apparentlymart in
hashicorp#3635 (comment)
to fix the issue of OpsWorks stacks always complaining about the custom
cookbooks SSH key needing to be changed.

Functional tests:

* Created a new stack and gave it an SSH key. The key was written to
  OpsWorks properly.
* Ran "plan" again and terraform indicated it needed to change the SSH
  key, which is expected since terraform cannot read what the existing
  SSH is.
* Removed the key from my resource and this time, "plan" did not have
  any changes. The `tfstate` file indicated the SSH key was "" (empty
  string).
* Changed an unrelated property of the stack. Previously this was not
  working for me due to terraform attempting to change the SSH key.
@apparentlymart
Copy link
Contributor

👍 LGTM! Thanks.

apparentlymart added a commit that referenced this pull request Dec 10, 2015
Make the OpsWorks cookbooks SSH key write only
@apparentlymart apparentlymart merged commit b679bb2 into hashicorp:master Dec 10, 2015
@b-ryan b-ryan deleted the fix/opsworks-ssh-key-write-only branch December 10, 2015 14:11
iroller pushed a commit to iroller/terraform that referenced this pull request May 12, 2016
Similarly to hashicorp#4241 prevent ssh_key in OpsWorks application app_source key from re-applying every time.
cristicalin pushed a commit to cristicalin/terraform that referenced this pull request May 24, 2016
Similarly to hashicorp#4241 prevent ssh_key in OpsWorks application app_source key from re-applying every time.
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS OpsWorks custom_cookbooks_source ssh_key keeps reapplying
2 participants